Skip to content

ui: show nicAdapter selection for VMware non-readfromova template#5429

Merged
yadvr merged 2 commits into
apache:4.15from
shapeblue:fix-ui-registertemplatenicadapter
Sep 10, 2021
Merged

ui: show nicAdapter selection for VMware non-readfromova template#5429
yadvr merged 2 commits into
apache:4.15from
shapeblue:fix-ui-registertemplatenicadapter

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Sep 10, 2021 •
edited
Loading

Description

NIC Adapter type option is missing in Register/Upload template form.
This PR fixes the behaviour

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:
Screenshot from 2021-09-10 14-52-41

After:
Screenshot from 2021-09-10 17-14-06

How Has This Been Tested?

Screenshot from 2021-09-10 14-39-06

@shwstppr
ui: show nicAdapter selection for non-readfromova template
6a588ec 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr marked this pull request as ready for review September 10, 2021 11:27
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 10, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr yadvr added this to the 4.15.2.0 milestone Sep 10, 2021
nvazquez
nvazquez approved these changes Sep 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shwstppr - LGTM

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5429 (SL-JID-624)

@shwstppr
show keyboardcontroller and ostype elements in different rows
2edb568 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 10, 2021

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5429 (SL-JID-625)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 10, 2021

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5429 (SL-JID-626)

@yadvr yadvr merged commit eba577c into apache:4.15 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@nvazquez nvazquez nvazquez approved these changes

@utchoang utchoang utchoang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.15.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @yadvr @nvazquez @utchoang